Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85802?usp=email )
Change subject: mb/google/fatcat/var/fatcat: Change touchpad interrupt to edge trigger ......................................................................
mb/google/fatcat/var/fatcat: Change touchpad interrupt to edge trigger
This change modifies the touchpad interrupt configuration to use edge-triggered interrupts instead of level-triggered interrupts.
This is necessary to ensure that the touchpad interrupt is properly detected by the AP w/o seeing interrupt flood.
BUG=b:376019577 TEST=Verified that the touchpad works smoothly with this change.
Change-Id: Ida0dfe10963a979c5e977133149d97799a76e3b3 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85802 Reviewed-by: Pranava Y N pranavayn@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/fatcat/variants/fatcat/fw_config.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Pranava Y N: Looks good to me, approved
diff --git a/src/mainboard/google/fatcat/variants/fatcat/fw_config.c b/src/mainboard/google/fatcat/variants/fatcat/fw_config.c index 6ac0755..87f9097 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/fw_config.c +++ b/src/mainboard/google/fatcat/variants/fatcat/fw_config.c @@ -440,7 +440,7 @@ /* GPP_F13: THC_I2C1_SDA_TCH_PAD */ PAD_CFG_NF(GPP_F13, NONE, DEEP, NF8), /* GPP_A13: TCH_PAD_INT_N */ - PAD_CFG_GPI_IRQ_WAKE(GPP_A13, NONE, PWROK, LEVEL, INVERT), + PAD_CFG_GPI_IRQ_WAKE(GPP_A13, NONE, PWROK, EDGE_SINGLE, INVERT), };
static const struct pad_config touchpad_i2c_disable_pads[] = {