[coreboot-gerrit] Change in coreboot[master]: drivers/gfx: Add generic graphics with SSDT generator

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36041 )

Change subject: drivers/gfx: Add generic graphics with SSDT generator
......................................................................

Patch Set 7: Code-Review-1

(1 comment)

https://review.coreboot.org/c/coreboot/+/36041/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36041/7//COMMIT_MSG@21 
PS7, Line 21:   register "device[0].privacy.detect_function" = ""\_SB.PCI0.PVSC.GPVD""
Why should you hardcode those values and not autodetect them at runtime?
You would have to keep devicetree, DSDT and SSDT in sync, which seems a bad idea.