Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )
Change subject: mainboard/amd: Add padmelon board code ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/... File src/mainboard/amd/padmelon/Kconfig:
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/... PS2, Line 37: config VGA_BIOS_FILE : string : default "3rdparty/blobs/soc/amd/merlinfalcon/VBIOS.bin"
Leave this section in, and just point to a stoney binary for now.
This was wrong, and already removed on patch set 3.
https://review.coreboot.org/c/coreboot/+/33993/3/src/mainboard/amd/padmelon/... File src/mainboard/amd/padmelon/Kconfig:
https://review.coreboot.org/c/coreboot/+/33993/3/src/mainboard/amd/padmelon/... PS3, Line 20: # select SOC_AMD_MERLINFALCON # missing binaries
By doing this, you're not testing any of the merlinfalcon code you've pushed. […]
Will do, though will create the config at 33621 and just select it once available.