Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44996 )
Change subject: Revert "soc/intel/common/block/*/Kconfig: Guard options with if-blocks" ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44996/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sgx/Kconfig:
https://review.coreboot.org/c/coreboot/+/44996/1/src/soc/intel/common/block/... PS1, Line 34: default 1 if SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_SIZE_1MB see below; drop this
https://review.coreboot.org/c/coreboot/+/44996/1/src/soc/intel/common/block/... PS1, Line 37: prompt "PRMRR size" this should depend on SOC_INTEL_COMMON_BLOCK_SGX_ENABLE
https://review.coreboot.org/c/coreboot/+/44996/1/src/soc/intel/common/block/... PS1, Line 38: if SOC_INTEL_COMMON_BLOCK_SGX_ENABLE this is unneeded when dropping 1MB and disabled
https://review.coreboot.org/c/coreboot/+/44996/1/src/soc/intel/common/block/... PS1, Line 39: default SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_DISABLED if !SOC_INTEL_COMMON_BLOCK_SGX_ENABLE see below; drop this
https://review.coreboot.org/c/coreboot/+/44996/1/src/soc/intel/common/block/... PS1, Line 64: config SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_SIZE_1MB : depends on !SOC_INTEL_COMMON_BLOCK_SGX_ENABLE # SGX depends on PRMRR >= 32 MiB : bool "1 MiB" : : config SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_DISABLED : depends on !SOC_INTEL_COMMON_BLOCK_SGX_ENABLE # SGX depends on PRMRR >= 32 MiB : bool "Disabled" : since SGX depends on PRMRR >= 32 MiB, these two can be dropped