Attention is currently required from: Jarried Lin, Yu-Ping Wu.
Gavin Liu has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/blobs/+/86382?usp=email )
Change subject: soc/mediatek/mt8196: Add libbl31.a version 16174.21.0 ......................................................................
Patch Set 3:
(11 comments)
File soc/mediatek/mt8196/README.md:
https://review.coreboot.org/c/blobs/+/86382/comment/09fb0f97_b64fe713?usp=em... : PS2, Line 287: Mediatek
MediaTek
Done
https://review.coreboot.org/c/blobs/+/86382/comment/d7085b69_3528f21f?usp=em... : PS2, Line 293: mminfra
Uppercase
Done
https://review.coreboot.org/c/blobs/+/86382/comment/85ab34a6_0012e849?usp=em... : PS2, Line 294: smmu_sid
Should this be uppercase as well (something like `SMMU SID`)?
Done
https://review.coreboot.org/c/blobs/+/86382/comment/db2e3949_acef07f9?usp=em... : PS2, Line 296: use
uses
Done
https://review.coreboot.org/c/blobs/+/86382/comment/94453cc5_ce032be4?usp=em... : PS2, Line 297: ARM-Trusted-Firmware links `libbl31.a` when building `bl31.elf`.
Done
https://review.coreboot.org/c/blobs/+/86382/comment/7b2b62aa_843053a4?usp=em... : PS2, Line 298:
Missing `## Version` section, which is a requirement for all upstream blobs.
Done
File soc/mediatek/mt8196/libbl31.a:
PS2:
Fix executable file mode.
Done
File soc/mediatek/mt8196/libbl31.a.md5:
https://review.coreboot.org/c/blobs/+/86382/comment/f707d097_fa7d43a6?usp=em... : PS2, Line 2:
extra blank line
Done
File soc/mediatek/mt8196/libbl31_release_note.txt:
https://review.coreboot.org/c/blobs/+/86382/comment/7caef88f_852b06a2?usp=em... : PS2, Line 1: 1.0
Can we use the latest version 16174.X. […]
Done. This library is from 16174.21.
https://review.coreboot.org/c/blobs/+/86382/comment/ce70b91f_ca1ff5d9?usp=em... : PS2, Line 5: Include
Included
Done
https://review.coreboot.org/c/blobs/+/86382/comment/8caee9f0_33038eb4?usp=em... : PS2, Line 7: - CL:*8004008 feat(mt8196): add MT8196 UFS driver
Sort from latest to the oldest (just like git log output)?
Done