build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 )
Change subject: mainboard/samsung/350v5c: update board_info.txt with correct info ......................................................................
Patch Set 2:
(18 comments)
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... File src/mainboard/samsung/350v5c/mainboard.c:
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 14: /* 00 */ 0x00, 0x00, 0x01, 0x00, 0x03, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 15: /* 10 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 16: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 17: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 18: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 19: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 20: /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 21: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 22: /* 80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 23: /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 24: /* a0 */ 0x00, 0x04, 0x00, 0x84, 0xc1, 0x00, 0x00, 0x61, 0x64, 0x00, 0x00, 0x08, 0x64, 0x19, 0x00, 0xd8, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 25: /* b0 */ 0x00, 0x00, 0xff, 0x33, 0x01, 0x00, 0x00, 0x00, 0x00, 0x07, 0x00, 0x0f, 0x00, 0x4b, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 26: /* c0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 27: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 28: /* e0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 29: /* f0 */ 0x00, 0x40, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 34: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/mainboa... PS2, Line 45: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); line over 80 characters