Attention is currently required from: Angel Pons, Arthur Heymans.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79754?usp=email )
Change subject: northbridge/intel/sandybridge: Enable x86_64 for mrc.bin ......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/sandybridge/mrc_wrapper.S:
https://review.coreboot.org/c/coreboot/+/79754/comment/25507dfd_a787932f : PS2, Line 37: mrc_console_wrapper: : /* Set up new stack frame */ : pushal : mov %esp, %ebp : : /* Align stack and make space for arguments */ : andl $0xfffffff0, %esp : subl $8, %esp : : /* Get argument */ : movl 36(%ebp), %eax : push %eax : : /* Get function to call */ : mov $do_putchar, %eax : push %eax : : /* : * Elevate to long mode. As 2nd and 3rd argument are unused they : * haven't been pushed to the stack. : */ : call long_mode_call_3arg : : /* Restore stack pointer */ : mov %ebp, %esp : popal
FSP also has callbacks into coreboot. […]
Replaced with a macro.