Attention is currently required from: Frank Chu, Isaac Lee, Tim Wawrzynczak.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56302 )
Change subject: mb/google/volteer/variants/collis: Redefine GPIO_EC_IN_RW to GPP_F17
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56302/comment/bb5a7c7e_46550e00
PS1, Line 11: none
Create a bug for this. I think the FAFT test should catch this problem.
https://review.coreboot.org/c/coreboot/+/56302/comment/66a764f1_f9f35a0a
PS1, Line 12: none
firmware-volteer-13672.B
https://review.coreboot.org/c/coreboot/+/56302/comment/ecd1efdf_a9dfb5d4
PS1, Line 13: none
It shouldn't be none. You need to make sure the pin is working correctly. For example, you can measure the gpio signal.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56302
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24f4803dc99ef3fc78852241f3a9e86ec70293d9
Gerrit-Change-Number: 56302
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anson Tseng
ansontseng@google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 14 Jul 2021 11:52:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment