EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32763 )
Change subject: mb/google/sarien: Add delay for EC sync
......................................................................
Patch Set 3:
Patch Set 2:
First if you want to inject a delay, delay in mainboard/EC level will be better instead of under soc directly, also I will recommend to find out why and how long a delay needed. Either some insight info from EC or base on some measurement of board will make more sense to me.
oh yes... this should move to wilco EC side.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ba48068f44ab2558199277f8dbbbbe9bcf249ff
Gerrit-Change-Number: 32763
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Comment-Date: Mon, 13 May 2019 05:33:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment