Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35849 )
Change subject: superio/nuvoton/nct5104d: Add virtual LDN for simple GPIO IO control ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35849/1/src/superio/nuvoton/nct5104... File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/35849/1/src/superio/nuvoton/nct5104... PS1, Line 127: reg = pnp_read_config(dev, 0x30); : pnp_write_config(dev, 0x30, reg & 0xFE);
Not exactly. […]
Ack
https://review.coreboot.org/c/coreboot/+/35849/2/src/superio/nuvoton/nct5104... File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/35849/2/src/superio/nuvoton/nct5104... PS2, Line 111: static void disable_gpio_io_port(struct device *dev)
I have decided to leave this function in place due to the possibility of devicetree + Kconfig (for a […]
Ack
https://review.coreboot.org/c/coreboot/+/35849/3/src/superio/nuvoton/nct5104... File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/35849/3/src/superio/nuvoton/nct5104... PS3, Line 169: }
maybe also print a warning?
Done