Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38057 )
Change subject: security: Move TS_{START,END}_TPMINIT out of vboot ......................................................................
Patch Set 1:
(1 comment)
I guess I should rename the vendor timestamps, so the numbers are kept?
We should keep the old numbers (even if these technically don't belong into the vboot block anymore now) so that the cbmem utility keeps working for old builds. Is that what you meant?
https://review.coreboot.org/c/coreboot/+/38057/1/src/security/vboot/vboot_lo... File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/38057/1/src/security/vboot/vboot_lo... PS1, Line 324: antirollback_read_space_firmware
We're losing the time this function takes. […]
I'd suggest creating a new TS_VBOOT_TPM_READ_DONE and logging it here, then we can differentiate init and read.