Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35014 )
Change subject: Move and rename ARCH_STAGE_HAS_xxx_SECTION rules ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h@277 PS5, Line 277: sometimes SRAM not DRAM
Doesn't this comment apply only to PRE_RAM stages?
Wording "sometimes" does not define when exactly one changes from SRAM to DRAM. Unlike Julius mentioned, I did not notice places where ARM code would exactly care about backing store in SRAM or DRAM. Maybe such distinction and this comment can be discussed in CB:34982?
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h@278 PS5, Line 278: #define ENV_STAGE_HAS_DATA_SECTION 1 : #define ENV_STAGE_HAS_BSS_SECTION 1
Can these be moved out of #if .. #else .. […]
CB:35016 and CB:35004 will touch these, making it more complex than !ENV_CACHE_AS_RAM for ARCH_X86. I wanted to keep !ARCH_X86 case clean.