Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44675 )
Change subject: cpu/x86/mp_init: Add support for x86_64 ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44675/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/44675/1/src/cpu/x86/mp_init.c@351 PS1, Line 351: uintptr_t Has the potential to overflow the uint32_t c_handler?
The problem is that the .module_parametrs has to match the struct entries size. Maybe a macro to be used in assembly for the pointer size could come in handy here and for the smm module parameters?