Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35606 )
Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35606/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35606/1//COMMIT_MSG@11
PS1, Line 11: paramter
parameter
Done
https://review.coreboot.org/c/coreboot/+/35606/1/util/mainboard/google/hatch...
File util/mainboard/google/hatch/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35606/1/util/mainboard/google/hatch...
PS1, Line 17: bug_number
bug_number -> b:bug_number
Done
https://review.coreboot.org/c/coreboot/+/35606/1/util/mainboard/google/hatch...
PS1, Line 35: text
BUG= text -> BUG=text
Clarified by rewording. "BUG=" was meant to function like an adjective, just like you might write "Assign replacement text, or 'None' if ..."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35606
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e08df5d80a5684c9f3675e3c0a8346240171cd3
Gerrit-Change-Number: 35606
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Andrew McRae
amcrae@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Sep 2019 15:26:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrew McRae
amcrae@chromium.org
Gerrit-MessageType: comment