Attention is currently required from: Andrey Petrov, Kapil Porwal, Paul Menzel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76921?usp=email )
Change subject: drivers/intel/fsp2_0: Add API to convert BMP images to GOP BLT buffer
......................................................................
Patch Set 7:
(1 comment)
File src/drivers/intel/fsp2_0/fsp_gop_blt.c:
PS3:
I meant just a lot of the helper functions introduced here.
To make the code readable better. (thats the motivation i had with helper functions)
Also, will “AMD FSP” ever use this?
AMD is using drivers/intel/fsp2_0 anyway hence, they should be able to use it if still using FSP. But as I said, this is SoC dependent code and not sure how cross-arch team will leverage that.
marking it resolved. Please let me know if any concern.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76921?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I992b45d65374f09498ff0cab497f7091e1e7a350
Gerrit-Change-Number: 76921
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 10 Aug 2023 11:01:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment