Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42499 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct mic pin configs
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
(2 comments)
NID 0x18 is MIC1 PORTB, NID 0x19 is MIC2 PORTF.
Verified that google/panther is actually using MIC2 through boardviews.
ALC283 mic pin descriptions:
- MIC 1: pins 22, 21
- MIC 2: pins 17, 18
On Panther, MIC 1 goes to testpoints and MIC 2 goes to the 3.5mm jack.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42499
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I172a0bb299049d113a0272ee9c790b25b6242cad
Gerrit-Change-Number: 42499
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 18 Jun 2020 14:49:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment