Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35237 )
Change subject: soc/intel/{cnl, icl}: Allocate 64KB as FSP heap
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35237/4/src/soc/intel/cannonlake/Kc...
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/35237/4/src/soc/intel/cannonlake/Kc...
PS4, Line 133: The amount of anticipated heap usage in CAR by FSP.
Can we add details here about where the size requirement is coming from i.e. doc# if any? Or at least the integration guide name?
https://review.coreboot.org/c/coreboot/+/35237/4/src/soc/intel/icelake/Kconf...
File src/soc/intel/icelake/Kconfig:
https://review.coreboot.org/c/coreboot/+/35237/4/src/soc/intel/icelake/Kconf...
PS4, Line 84: The amount of anticipated heap usage in CAR by
Same here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35237
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc39cdb71f427189186222ae53b8881cbbd5e0bc
Gerrit-Change-Number: 35237
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Sep 2019 17:17:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment