Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35727 )
Change subject: intel/pci_devs: Regroup PCI xx_DEVID entries
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35727/2/src/soc/intel/braswell/incl...
File src/soc/intel/braswell/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/35727/2/src/soc/intel/braswell/incl...
PS2, Line 156: #define SMBUS_DEVID 0x0f12
Yeah, Intel could do their share...
Can we submit this, moving will force renaming these as well, maybe we do not want to squash that all together here? This one is currently blocking other changes on <soc/pci_devs.h>.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35727
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I953e9a7746232b4c40deca55eb6cb3bd7af91496
Gerrit-Change-Number: 35727
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Oct 2019 18:55:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment