[coreboot-gerrit] [M] Change in coreboot[main]: arch/riscv: Basic illegal instruction handling

[Paul Menzel (Code Review)]

Attention is currently required from: Philipp Hug, ron minnich.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81306?usp=email )

Change subject: arch/riscv: Basic illegal instruction handling
......................................................................

Patch Set 11:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81306/comment/ba4cd7d3_2e487087 :
PS11, Line 7: arch/riscv: Basic illegal instruction handling
Just a nit: It’d be great if you made this a statement by adding a verb in imperative mood. Maybe: Add basic …

https://review.coreboot.org/c/coreboot/+/81306/comment/f4c67ffc_01eee394 :
PS11, Line 23: 
Other nit: The blank line can be removed.

File src/arch/riscv/trap_handler.c:

https://review.coreboot.org/c/coreboot/+/81306/comment/96dda3f1_d01d0fe5 :
PS11, Line 116: testing_linuxcheck
Mention this in the commit message too?

https://review.coreboot.org/c/coreboot/+/81306/comment/48484970_3e3b17c6 :
PS11, Line 128: provided
provide