[coreboot-gerrit] Change in coreboot[master]: lib/fmap: Add optional pre-RAM cache

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36657 )

Change subject: lib/fmap: Add optional pre-RAM cache
......................................................................

Patch Set 7:

(4 comments)

https://review.coreboot.org/c/coreboot/+/36657/7/src/include/memlayout.h 
File src/include/memlayout.h:

https://review.coreboot.org/c/coreboot/+/36657/7/src/include/memlayout.h@79 
PS7, Line 79: #define FMAP_CACHE(addr, sz) \
Macros with multiple statements should be enclosed in a do - while loop

https://review.coreboot.org/c/coreboot/+/36657/7/src/include/memlayout.h@79 
PS7, Line 79: #define FMAP_CACHE(addr, sz) \
macros should not use a trailing semicolon

https://review.coreboot.org/c/coreboot/+/36657/7/src/include/memlayout.h@82 
PS7, Line 82: 		   STR(FMAP does not fit in FMAP_CACHE! (sz < FMAP_SIZE)));
space required before that '!' (ctx:VxW)

https://review.coreboot.org/c/coreboot/+/36657/7/src/include/memlayout.h@82 
PS7, Line 82: 		   STR(FMAP does not fit in FMAP_CACHE! (sz < FMAP_SIZE)));
space prohibited after that '!' (ctx:VxW)