8 Aug
2019
8 Aug
'19
3:34 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34772 )
Change subject: soc/mediatek: dsi: Refactor video timing calculation ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34772/6/src/soc/mediatek/common/dsi... File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/34772/6/src/soc/mediatek/common/dsi... PS6, Line 212: less than Is "not greater than" better?
https://review.coreboot.org/c/coreboot/+/34772/6/src/soc/mediatek/common/dsi... PS6, Line 240: PIXEL_STREAM_CUSTOM_HEADER << 26 What's the meaning of "0 << 26" here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34772
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3ad2edc08787414a74188f5050460e98222caf4
Gerrit-Change-Number: 34772
Gerrit-PatchSet: 6
Gerrit-Owner: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu yongqiang.niu@mediatek.com
Gerrit-Comment-Date: Thu, 08 Aug 2019 01:34:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment