Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37282 )
Change subject: soc/intel/common/block/cse: Rename set_host_ready() to cse_set_host_ready() ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37282/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37282/3//COMMIT_MSG@7 PS3, Line 7: soc/intel/common/block/cse: Rename set_host_ready() to cse_set_host_ready() The line is too long, 72 is the maximum and <65 is recommended.
The prefix doesn't have to be a full path, `intel/cse` is all that matters.
https://review.coreboot.org/c/coreboot/+/37282/3//COMMIT_MSG@11 PS3, Line 11: 2. Additional debug messages are added These are not even in set_host_ready(), please find a better summary line that doesn't hide changes. Or even better, don't list unrelated changes but make them individual commits.
https://review.coreboot.org/c/coreboot/+/37282/3/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/37282/3/src/soc/intel/common/block/... PS3, Line 289: BIOS_ERR Not an error message.