Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46758 )
Change subject: soc/intel/broadwell/pch/acpi/irqlinks.asl: Add missing IRQs ......................................................................
Patch Set 10:
Patch Set 10:
Patch Set 10:
Patch Set 10: Code-Review+2
Why blow up the patch train with that? A note in the follow-up that using common code involves added missing IRQs would have been enough IMO
Ah, I see why that was done (timeless check)
Yes, I prefer to have a small patch that explains why adding these IRQs is fine, and then a big change that is reproducible. I do this quite often, and if reviewers know about it, then I feel it makes things easier to review. :)
Yup, ack ;-) All fine