build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47431 )
Change subject: soc/intel/common: Generate the CSE RW metadata and add to FW_MAIN_A/B ......................................................................
Patch Set 1:
(21 comments)
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse_rw_metadata.c:
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 24: .version = { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 25: .major = CSE_RW_MAJOR, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 25: .major = CSE_RW_MAJOR, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 26: .minor = CSE_RW_MINOR, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 26: .minor = CSE_RW_MINOR, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 27: .build = CSE_RW_BUILD, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 27: .build = CSE_RW_BUILD, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 28: .hotfix = CSE_RW_HOTFIX, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 28: .hotfix = CSE_RW_HOTFIX, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 29: }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 30: .sha256 = HASH_BYTEARRAY(CSE_RW_SHA256), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 68: uint16_t major; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 68: uint16_t major; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 69: uint16_t minor; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 69: uint16_t minor; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 70: uint16_t hotfix; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 70: uint16_t hotfix; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 71: uint16_t build; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 71: uint16_t build; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 80: struct fw_version version; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47431/1/src/soc/intel/common/block/... PS1, Line 81: uint8_t sha256[SHA256_DIGEST_SIZE]; please, no spaces at the start of a line