Attention is currently required from: Angel Pons.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47962 )
Change subject: mb/system76/oryp5: Enable TAS5825M smart amp
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/system76/oryp5/tas5825m.c:
https://review.coreboot.org/c/coreboot/+/47962/comment/f00c7ba4_2fd1d5bf
PS5, Line 8: return
You could also rewrite this with arrays
Could you clarify how using arrays would resolve checking the return?
I could use amp_write_block_at() to significantly cut down on the number of calls by passing byte arrays, but I'm still checking the return on every write.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47962
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I148f18ff3e754d913bdf907121b103c6de02ffc3
Gerrit-Change-Number: 47962
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 27 Jan 2021 16:19:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford
tcrawford@system76.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment