Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30886 )
Change subject: soc/intel: Enable console in bootblock
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30886/1/src/soc/intel/cannonlake/Kconfig
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/30886/1/src/soc/intel/cannonlake/Kconfig@29
PS1, Line 29: select BOOTBLOCK_CONSOLE
BOOTBLOCK_CONSOLE has a prompt, thus it's a user option. With
the `select` you remove that option. So overriding the default
would be much preferred.
NB. I wonder why it's disabled by default. Maybe some
platforms don't want it for performance reasons. IMHO, we
should override the default for these and have a global
default `y` instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30886
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0aa98575eeb14d4c5387415d3fde4677a6b7ffe6
Gerrit-Change-Number: 30886
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sat, 12 Jan 2019 23:59:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment