[coreboot-gerrit] Change in coreboot[master]: Revert "{drivers,soc/intel/braswell}: Implement C_ENVIRONMENT_BOOTBLO...

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34304 )

Change subject: Revert "{drivers,soc/intel/braswell}: Implement C_ENVIRONMENT_BOOTBLOCK support"
......................................................................

Patch Set 1:
> Patch Set 1:
> > Patch Set 1:
> > > Patch Set 1:
> > > > Patch Set 1: Code-Review-1
> > > >
> > > > Facebook FBG1701 is based on this commit.
> > > > Can I assist solving this issue on Google/Cyan?
> > >
> > > It has been a month since the issue with google/cyan was known. I would prefer if you could test that FBG1701 boots properly with this change, so that the coreboot 4.10 release is working on google/cyan and FBG1701. Then we could try to get C_ENVIRONMENT_BOOTBLOCK to work without master being broken.
> >
> > Did a test today, but system did not boot till the end.
> > Need some more investigation.
>
> Got any logs?

I rebuild today and the system is booting.
However not having bootblock in C provides weak verified boot and measured boot solution for Facebook FBG1701.

First patch sets of https://review.coreboot.org/c/coreboot/+/29662 provide solution where C_ENVIRONMENT_BOOTBLOCK was configurable. This would mean actual boards are not upgrades and new boards can use C_ENVIRONMENT_BOOTBLOCK.
The comment was that all boards should be upgraded to C_ENVIRONMENT_BOOTBLOCK.

I suggest using (and fix Google/Cyan) C_ENVIRONMENT_BOOTBLOCK or make C_ENVIRONMENT_BOOTBLOCK optional.