Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36418 )
Change subject: cpu/x86: Introduce .near_reset_vector ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/entry16.i... File src/cpu/x86/16bit/entry16.inc:
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/entry16.i... PS3, Line 34: #endif I would drop the C_ENV_BOOTBLOCK_SIZE condition here. The assembly we put in .near_reset_vector has to fit that section (<4 KiB) or otherwise builds attempting to increase the bootblock size can fail.
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/entry16.i... PS3, Line 41: .align 4096 I understand some people are a bit upset having the bootblock size increased, only SIPI_VECTOR_IN_ROM needs the .align here.
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/reset16.l... File src/cpu/x86/16bit/reset16.ld:
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/reset16.l... PS3, Line 29: #endif I think you could do all of the above unconditionally. Some people with very tight flashspace would like to see the entire bootblock top-aligned.