Attention is currently required from: Felix Singer, Maxim Polyakov, Angel Pons, Christoph Pomaska.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7
......................................................................
Patch Set 17:
(1 comment)
File src/mainboard/gigabyte/ga-z170x-gaming7/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/38920/comment/1181c8ea_5a379c44
PS13, Line 29: DP2, -- The board's HDMI port
Unfortunately I'm not sure what to conclude from here. […]
HDMI1 would require DDPB_CTRLCTL/_CTRLDATA to be connected via a mux to the DP
port. If Angel was right, that is not the case, so *no* HDMI1.
I'd say either
(DP1, DP2, others => Disabled)
or
(DP1,
DP2,
DP3, -- untested TBT connection
others => Disabled)
Marking as resolved as the code already does the first thing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38920
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c69bddd22cbd8f797dbb57370a4d8e5afa63bc
Gerrit-Change-Number: 38920
Gerrit-PatchSet: 17
Gerrit-Owner: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Christoph Pomaska
github@slrie.de
Gerrit-Comment-Date: Thu, 02 Mar 2023 11:43:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Christoph Pomaska
github@slrie.de
Gerrit-MessageType: comment