Attention is currently required from: Arthur Heymans, Kapil Porwal, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/81968?usp=email )
Change subject: libpayload: Add x86_64 (64-bit) support ......................................................................
Patch Set 76:
(1 comment)
File payloads/libpayload/arch/x86/head_64.S:
https://review.coreboot.org/c/coreboot/+/81968/comment/d75f3207_f2e9e613?usp... : PS76, Line 59: #include "multiboot_header.inc" Sorry, I just realized this doesn't work because `rdmsr` clobbers EAX (and there's no way to get that instruction to use a different register, right?). So the loader_eax/loader_ebx saving needs to happen before that. I think that's fine because all the included file does is a jump and two moves, that should be fine in both 32 and 64-bit mode.
So need to move this `#include` to the top of `_entry`.