Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31349 )
Change subject: lib/bootblock: Sanitize CMOS after bootblock_*_early_init()
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31349/3/src/lib/bootblock.c
File src/lib/bootblock.c:
https://review.coreboot.org/#/c/31349/3/src/lib/bootblock.c@a45
PS3, Line 45:
The call to enable_rtc_upper_bank() were like just the previous executed instructions if running wit […]
Interesting thought, I'll have to check. Altough it's unlikely that I had
timestamps disabled, it's not a huge delay anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31349
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e1a029e4be7e109be43a3dad944bd7e05ea1f02
Gerrit-Change-Number: 31349
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 18 Mar 2019 17:07:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment