[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Fix GPP_E12 definition

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45197 )

Change subject: mb/google/volteer: Fix GPP_E12 definition
......................................................................

mb/google/volteer: Fix GPP_E12 definition

GPP_E12 should not be defined in the baseboard as its use is
determined by the variant. For legacy reasons, we still have GPP_E12
defined in early_gpio but should not. Malefor and volteer* have the
same GPP_E12 definition, but that is a misconfiguration. I think that
was a copy-paste that slipped through the reviews.

BUG=b:157597158
TEST=volteer2 boots to the OS

Change-Id: Ic3ef864827aa94b0b96e335565119f3d5d008837
Signed-off-by: Caveh Jalali 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45197
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Nick Vaccaro 
---
M src/mainboard/google/volteer/variants/baseboard/gpio.c
M src/mainboard/google/volteer/variants/malefor/gpio.c
M src/mainboard/google/volteer/variants/volteer/gpio.c
M src/mainboard/google/volteer/variants/volteer2/gpio.c
4 files changed, 0 insertions(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Nick Vaccaro: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c
index c938b28..5d367e7 100644
--- a/src/mainboard/google/volteer/variants/baseboard/gpio.c
+++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c
@@ -422,9 +422,6 @@
    /* C21 : UART2_TXD ==> H1_PCH_INT_ODL */
    PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT),

-	/* E12 : SPI1_MISO_IO1 ==> EN_PP3300_SSD */
-	PAD_CFG_GPO(GPP_E12, 1, DEEP),
-
    /* F11 : THC1_SPI2_CLK ==> EN_PP3300_WWAN */
    PAD_CFG_GPO(GPP_F11, 1, DEEP),
 };
diff --git a/src/mainboard/google/volteer/variants/malefor/gpio.c b/src/mainboard/google/volteer/variants/malefor/gpio.c
index 22dec73..90ad354 100644
--- a/src/mainboard/google/volteer/variants/malefor/gpio.c
+++ b/src/mainboard/google/volteer/variants/malefor/gpio.c
@@ -186,9 +186,6 @@
    /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */
    PAD_CFG_GPO(GPP_D16, 1, DEEP),

-	/* E12 : SPI1_MISO_IO1 ==> PEN_ALERT_ODL */
-	PAD_CFG_GPO(GPP_E12, 1, DEEP),
-
    /* H11 : SRCCLKREQ5# ==> WLAN_PERST_L */
    PAD_CFG_GPO(GPP_H11, 1, DEEP),
 };
diff --git a/src/mainboard/google/volteer/variants/volteer/gpio.c b/src/mainboard/google/volteer/variants/volteer/gpio.c
index bd84585..422764e 100644
--- a/src/mainboard/google/volteer/variants/volteer/gpio.c
+++ b/src/mainboard/google/volteer/variants/volteer/gpio.c
@@ -234,9 +234,6 @@
    /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */
    PAD_NC(GPP_D16, UP_20K),

-	/* E12 : SPI1_MISO_IO1 ==> EN_PP3300_SSD */
-	PAD_CFG_GPO(GPP_E12, 1, DEEP),
-
    /* F11 : THC1_SPI2_CLK ==> EN_PP3300_WWAN */
    PAD_CFG_GPO(GPP_F11, 1, DEEP),
    /* F12 : GSXDOUT ==> WWAN_RST_ODL
diff --git a/src/mainboard/google/volteer/variants/volteer2/gpio.c b/src/mainboard/google/volteer/variants/volteer2/gpio.c
index 7255423..124f220 100644
--- a/src/mainboard/google/volteer/variants/volteer2/gpio.c
+++ b/src/mainboard/google/volteer/variants/volteer2/gpio.c
@@ -234,9 +234,6 @@
    /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */
    PAD_NC(GPP_D16, UP_20K),

-	/* E12 : SPI1_MISO_IO1 ==> EN_PP3300_SSD */
-	PAD_CFG_GPO(GPP_E12, 1, DEEP),
-
    /* F11 : THC1_SPI2_CLK ==> EN_PP3300_WWAN */
    PAD_CFG_GPO(GPP_F11, 1, DEEP),
    /* F12 : GSXDOUT ==> WWAN_RST_ODL