Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31954 )
Change subject: vendorcode/intel/../icelake: Update ICL FSP header BIOS version 3092
......................................................................
Patch Set 14: Code-Review-1
(1 comment)
There is something that does not look alright...
https://review.coreboot.org/#/c/31954/14/src/vendorcode/intel/fsp/fsp2_0/ice...
File src/vendorcode/intel/fsp/fsp2_0/icelake/MemInfoHob.h:
https://review.coreboot.org/#/c/31954/14/src/vendorcode/intel/fsp/fsp2_0/ice...
PS14, Line 7: INTEL CONFIDENTIAL
Is this copyright notice change correct?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31954
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8924dbf4a8d6a303540ced1c9c48586d26d6beaa
Gerrit-Change-Number: 31954
Gerrit-PatchSet: 14
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Jun 2019 08:30:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment