Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33565 )
Change subject: mb/asrock/h110m: rewrite gpio config using macros
......................................................................
Patch Set 2:
Patch Set 1:
Is the output of inteltool the same with/without this patch?
Yes, but after this patch we will not write to the INTSEL field in DW1 register, which is read-only.
I think the GPIOs configuration in this form is more understandable.
In addition, I will add new versions of boards with the GPIO configuration in this form.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01ad4bd29235fbe2b23abce5fbaaa7e63c87f529
Gerrit-Change-Number: 33565
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
m.poliakov@yahoo.com
Gerrit-Comment-Date: Tue, 18 Jun 2019 08:56:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment