[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: implement the dramc init setting

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34988 )

Change subject: mediatek/mt8183: implement the dramc init setting
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/dra... 
File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:

https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/dra... 
PS2, Line 102: 1
compare with real meaning (ODT_ON, ODT_OFF) instead.

https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/inc... 
File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h:

https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/inc... 
PS2, Line 119: 0x2
Can we replace these magic numbers by enum or #ifdef values?