Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44703 )
Change subject: soc/mediatek/mt8192: Do EMI init before dram calibration ......................................................................
Patch Set 41:
(8 comments)
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi... File src/soc/mediatek/mt8192/emi.c:
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi... PS2, Line 301: emi_mdl_init
Also, remove emi_init2 from CB:44699.
Ack
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi... PS2, Line 374: 2
emi_init func is at line: 293 in this file. […]
Ack
https://review.coreboot.org/c/coreboot/+/44703/2/src/soc/mediatek/mt8192/emi... PS2, Line 374: emi_init2
why move to this change?
Ack
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... File src/soc/mediatek/mt8192/emi.c:
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... PS41, Line 362: setting_2 setting2
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... PS41, Line 371: write32(&emi_reg->chn_hash0, read32(&emi_reg->chn_hash0) | emi_temp_data); Use clrsetbits32()
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... PS41, Line 386: write32(&ch[0].emi_chn.rkarb0, read32(&ch[0].emi_chn.rkarb0) | tmp); Use clrsetbits32()
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... PS41, Line 389: u32 void
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... PS41, Line 389: u32 void