Attention is currently required from: Tim Wawrzynczak, Wisley Chen, Zhuohao Lee, Elyes Haouas.
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67704 )
Change subject: soc/intel/jasperlake: Add UWES ASL into xhci.asl
......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/jasperlake/acpi/xhci.asl:
https://review.coreboot.org/c/coreboot/+/67704/comment/8dbce958_66fe9ca6
PS2, Line 22: ShiftLeft
Would you use ASL 2.0 Syntax? […]
Done
https://review.coreboot.org/c/coreboot/+/67704/comment/608a8a2f_6256d0aa
PS2, Line 33: Local0 = Local0 & RO_BITS_OFF_MASK
Local0 &= RO_BITS_OFF_MASK
Done
https://review.coreboot.org/c/coreboot/+/67704/comment/f1713b10_381d1fc2
PS2, Line 35: Local0 = Local0 | WAKE_ON_CONNECT_DISCONNECT_ENABLE
Local0 |= WAKE_ON_CONNECT_DISCONNECT_ENABLE
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67704
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1694fc9535431091c638f2dd1b3680a55b22430a
Gerrit-Change-Number: 67704
Gerrit-PatchSet: 3
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 21 Sep 2022 07:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment