Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34078 )
Change subject: arch/x86: Clean up PIRQ_ROUTE
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34078/2/src/arch/x86/pirq_routing.c
File src/arch/x86/pirq_routing.c:
https://review.coreboot.org/c/coreboot/+/34078/2/src/arch/x86/pirq_routing.c...
PS2, Line 145: u8 bus = pirq_tbl->slots[i].bus;
: u8 devfn = pirq_tbl->slots[i].devfn;
Should these be const?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I140e15d584d3f60f7824bcb71ce63724c11e3f46
Gerrit-Change-Number: 34078
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Jul 2019 09:56:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment