Attention is currently required from: Stefan Ott, Angel Pons, Arthur Heymans, Alexander Couzens.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69297 )
Change subject: cpu/intel/speedstep: Have nb and sb code provide c5/c6/slfm
......................................................................
Patch Set 18: Code-Review+1
(2 comments)
File src/northbridge/intel/gm45/northbridge.c:
https://review.coreboot.org/c/coreboot/+/69297/comment/7ab44db5_5290f895
PS18, Line 264: __pci_0_00_0
Shall this better be 'pcidev_on_root(0, 0);'?
File src/southbridge/intel/i82801ix/lpc.c:
https://review.coreboot.org/c/coreboot/+/69297/comment/f2f52bb4_99b44bb3
PS18, Line 143: __pci_0_1f_0
pcidev_on_root(0x1f, 0)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69297
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a9b1e684a7927259adae9b1d42a67e907722109
Gerrit-Change-Number: 69297
Gerrit-PatchSet: 18
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Stefan Ott
coreboot@desire.ch
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Ott
coreboot@desire.ch
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:43:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment