build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46407 )
Change subject: WIP: dcm: mt8192: Enable DCM ......................................................................
Patch Set 13:
(10 comments)
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/pll.h:
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/in... PS13, Line 310: INFRACFG_AO_AXIMEM_BUS_DCM_REG0_MASK = ((0x1f << 12) | \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/in... PS13, Line 313: INFRACFG_AO_AXIMEM_BUS_DCM_REG0_ON = ((0x10 << 12) | \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/in... PS13, Line 316: INFRACFG_AO_INFRA_BUS_DCM_REG0_MASK = ((0x1 << 0) | \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/in... PS13, Line 325: INFRACFG_AO_INFRA_BUS_DCM_REG0_ON = ((0x1 << 0) | \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/in... PS13, Line 340: INFRACFG_AO_PERI_BUS_DCM_REG0_MASK = ((0x1 << 0) | \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/in... PS13, Line 349: INFRACFG_AO_PERI_BUS_DCM_REG0_ON = ((0x1 << 0) | \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/in... PS13, Line 358: INFRACFG_AO_PERI_MODULE_DCM_REG0_MASK = ((0x1 << 29) | \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/in... PS13, Line 360: INFRACFG_AO_PERI_MODULE_DCM_REG0_ON = ((0x1 << 29) | \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/pl... File src/soc/mediatek/mt8192/pll.c:
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/pl... PS13, Line 438: INFRACFG_AO_INFRA_CONN_BUS_DCM_REG0_MASK, INFRACFG_AO_INFRA_CONN_BUS_DCM_REG0_ON); line over 96 characters
https://review.coreboot.org/c/coreboot/+/46407/13/src/soc/mediatek/mt8192/pl... PS13, Line 440: INFRACFG_AO_INFRA_CONN_BUS_DCM_REG1_MASK, INFRACFG_AO_INFRA_CONN_BUS_DCM_REG1_ON); line over 96 characters