Attention is currently required from: Jonathon Hall, Jérémy Compostella, Nico Huber.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78906?usp=email )
Change subject: drivers/pc80/rtc/option.c: Reset only checked CMOS range during resume
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS4:
I agree to the patch, just want to mention that this will most […]
Then we could restore the checked range only during s3 resume, while restore the whole CMOS after 14 during normal boot, as did in the Patchset 6.
File src/drivers/pc80/rtc/option.c:
https://review.coreboot.org/c/coreboot/+/78906/comment/b6cb2f20_3e77fecf :
PS4, Line 217: for (i = LB_CKS_RANGE_START; i < MIN(LB_CKS_RANGE_END, length); i++)
@Bill It looks like the range end is inclusive, so `LB_CKS_RANGE_END+1` here. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78906?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I872bf5f41422bc3424cd8631e932aaae2ae82f7a
Gerrit-Change-Number: 78906
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Comment-Date: Fri, 03 Nov 2023 14:34:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-MessageType: comment