Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33198 )
Change subject: Makefile.inc: Add macro to link a file in all stages
......................................................................
Patch Set 6:
I'd rather go for a new class ("all"?) with special behavior (namely: paste into all other classes). That way, it's not "$(call mumblejumble,beware,of,the,commas)" but "all-$(CONFIG_FOO) += bar.c"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I955dd2dc22cb3cfc4fdf1198cfd32f56475f97c9
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Jun 2019 11:37:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment