Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38778 )
Change subject: vboot: correct workbuf size when VBOOT_STARTS_IN_ROMSTAGE ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38778/1/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/38778/1/src/security/vboot/common.c... PS1, Line 108: rv = vb2api_init(wb_cbmem, cbmem_size, &vboot_ctx); nit: not sure if it's a great idea for visibility to pull the if and the else so far apart from each other. I'd consider either using braces and moving the comments into the respective blocks, or putting the whole comment describing both cases atop the if.