Philipp Hug has posted comments on this change. ( https://review.coreboot.org/29023 )
Change subject: riscv: add support smp_pause / smp_resume ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/29023/7/src/arch/riscv/smp.c File src/arch/riscv/smp.c:
https://review.coreboot.org/#/c/29023/7/src/arch/riscv/smp.c@24 PS7, Line 24: if (read_csr(mhartid) != working_hartid) {
Can we move this check outside of this function to make the flow clearer? […]
Or as an alternative: make it more clear that this function must be called by all harts. Also add synchronization code here to make sure all harts are here, before continuing on hart 0.