Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43137 )
Change subject: armv7: mmu: Use 'tlbimva' to invalidate TLB entries ......................................................................
Patch Set 1:
(2 comments)
I don't have any armv7 hardware that coreboot already works on (and the QEMU port doesn't seem like it currently works?), so would appreciate help in testing this. That said - if I understand the ARM architecture reference manual, it should be a safe change to make because (as stated in the commit) the tlbimva/tlbimvaa operations are equivalent when used on global TLB pages.
Thanks for the patch and welcome to coreboot! Based on your explanation and that you have tested it on your hardware, I'm happy to just take this patch without further testing. If it works for you it should work on other platforms too.
Please check out the line comments and upload another version with those addressed (at least the one about removing the function), then I'll approve it!
https://review.coreboot.org/c/coreboot/+/43137/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43137/1//COMMIT_MSG@25 PS1, Line 25: b nit: 'v'
https://review.coreboot.org/c/coreboot/+/43137/1/src/arch/arm/include/armv7/... File src/arch/arm/include/armv7/arch/cache.h:
https://review.coreboot.org/c/coreboot/+/43137/1/src/arch/arm/include/armv7/... PS1, Line 77: static inline void tlbimvaa(unsigned long mva) Let's just remove this function completely so we can be sure it's not still accidentally used anywhere.