Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42277 )
Change subject: mb/ocp/deltalake: Update SMBIOS type 2 Location In Chassis from BMC
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42277/6/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/ipmi.h:
https://review.coreboot.org/c/coreboot/+/42277/6/src/mainboard/ocp/deltalake...
PS6, Line 8: #define IPMI_NETFN_OEM 0x30
I was referencing the alignment style in […]
See comment below
https://review.coreboot.org/c/coreboot/+/42277/6/src/mainboard/ocp/deltalake...
PS6, Line 11:
I am referencing to this here which does not align with the other options
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42277
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b65ecc6f6421d85d1cb890c522be4787362a01b
Gerrit-Change-Number: 42277
Gerrit-PatchSet: 8
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 09:34:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Gerrit-MessageType: comment
