Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33055 )
Change subject: soc/sifive/fu540: add code for spi and map flash to memory spaces
......................................................................
Patch Set 12:
Patch Set 12:
Patch Set 12:
Have anything update?
I currently don't have hardware to test. I'll run test next week and give you feedback.
I tested.
Without this patch, you need to make the following modifications to run on real hardware.
diff --git a/src/mainboard/sifive/hifive-unleashed/Kconfig b/src/mainboard/sifive/hifive-unleashed/Kconfig
Index 24531787ef..db1d9aa54a 100644
--- a/src/mainboard/sifive/hifive-unleashed/Kconfig
+++ b/src/mainboard/sifive/hifive-unleashed/Kconfig
@@ -16,9 +16,10 @@ if BOARD_SIFIVE_HIFIVE_UNLEASHED
Config BOARD_SPECIFIC_OPTIONS
Def_bool y
Select SOC_SIFIVE_FU540
- select BOARD_ROMSIZE_KB_32768
+ select BOARD_ROMSIZE_KB_16384
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I106688c65ac7dd70be7479dc4691797b700682d9
Gerrit-Change-Number: 33055
Gerrit-PatchSet: 12
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 24 Jul 2019 07:15:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment