Attention is currently required from: Arthur Heymans, Nicholas Chin, Fabian Groffen, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73097 )
Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ......................................................................
Patch Set 2:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73097/comment/3f5a21d5_ad4e884b PS2, Line 30: i915 nit: That's the name of the Linux kernel driver. Since i915 is a Pentium 4 northbridge (much older than Sandy/Ivy Bridge), it would be best to omit it.
File src/mainboard/asrock/b75m-itx/Kconfig:
https://review.coreboot.org/c/coreboot/+/73097/comment/21591234_0be94f03 PS2, Line 5: config BOARD_SPECIFIC_OPTIONS Your board lacks a serial port, you should add `select NO_UART_ON_SUPERIO`
File src/mainboard/asrock/b75m-itx/acpi/pci.asl:
PS2: Remove, your board does not have a conventional PCI port.
File src/mainboard/asrock/b75m-itx/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/73097/comment/5db738d4_4b25cf07 PS2, Line 3: #undef SUPERIO_DEV : #define SUPERIO_DEV SIO0 : #define SUPERIO_PNP_BASE 0x2e This does nothing. You should include some pc80 keyboard.asl file, see other boards for the exact filename.
File src/mainboard/asrock/b75m-itx/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/73097/comment/d084e11c_4efd9095 PS2, Line 84: device pci 1e.0 on # PCI bridge : subsystemid 0x1849 0x244e : end Disable, your board does not have a conventional PCI port.
File src/mainboard/asrock/b75m-itx/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/73097/comment/2feaaec4_ad19a86b PS2, Line 26: #include "acpi/pci.asl" Remove, your board does not have a conventional PCI port.
File src/mainboard/asrock/b75m-itx/early_init.c:
https://review.coreboot.org/c/coreboot/+/73097/comment/b860e7a5_76b06ea0 PS2, Line 19: read_spd(&spd[0], 0x50, id_only); : read_spd(&spd[1], 0x51, id_only); : read_spd(&spd[2], 0x52, id_only); : read_spd(&spd[3], 0x53, id_only); Your board only has 2 DIMM slots. This would be more precise, but please test to make sure both DIMM slots still work:
``` read_spd(&spd[0], 0x50, id_only); read_spd(&spd[2], 0x52, id_only); ```
File src/mainboard/asrock/b75m-itx/gpio.c:
PS2: How did you make this file? Ideally, you should use `util/autoport`, get the logs while running vendor firmware.