Attention is currently required from: Felix Singer, Tarun Tuli, Subrata Banik, Dinesh Gehlot, Kapil Porwal, Lean Sheng Tan, Werner Zeh.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73133 )
Change subject: soc/intel/cmn/block/cse: ME source code at common location
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/cse/cse_me.c:
https://review.coreboot.org/c/coreboot/+/73133/comment/9b58268c_975aaa73
PS5, Line 11: /*
: * ME manufacturing mode is disabled if the descriptor is locked and fuses
: * are programmed. Additionally, if the SoC supports manufacturing variable, should be locked.
: */
u can drop this
More information can't hurt, can they?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6622662fd3b8bcc9d9ac8bd6ffa732f5d78801a
Gerrit-Change-Number: 73133
Gerrit-PatchSet: 5
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 21 Feb 2023 18:48:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment