Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39345 )
Change subject: mb/google/volteer: Enable DPTF functionality ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... PS3, Line 54: variant/acpi/dptf.asl You need to add this under variant/ripto and variant/volteer and include baseboard/dptf.asl from there.
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... PS3, Line 56: tigerlake_dev This is not correct.
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... PS3, Line 151: Device4Enable This is not used by TGL SoC code. Also, what device is this?
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/39345/3/src/mainboard/google/voltee... PS3, Line 138: 64000 Shouldn't this match what is in the devicetree?